Re: [hylafax-users] New faxrcvd

[Giulio Orsero <giulioo@pobox.com>]

On Sat, 30 Jun 2001 12:38:10 -0500, you wrote:

>I have finished working on a new faxrcvd. Have a look and if you like what you
>see, by all means use it. I have made a lot of changes so I decided to post the
>whole file instead of just a patch. -Jeremy

1) I would make more evident the fact that every variable change should me made
in FaxDispatch, before INFO:

########################################
#  If you want to change a variable do it in etc/FaxDispatch
########################################


2) why different handling for conversion to ps (eval)? Why not like the others
TIFF2PS_OPTS="-a "
$TIFF2PS $TIFF2PS_OPTS -O recvq/${FILENAME}.ps


3)
NTFYTOADDR="yes"                           # Send a notification to $TOADDR
should be
NTFYTOADDR="yes"     # Send a notice even if the fax is received ok

maybe
NTFY_SUCCESS


4) Using TIFF2PS in place of ps2fax for ps output too will break if some system
has not that binary that was not used in the past.
I understand this is difficult with the new layout that convert to ps first, and
then maybe convert to something else; I think that if you want to maintain this
more ordered layout you'll have to

FAX2PS=$TIFFBIN/fax2ps
TIFF2PS=tiff2ps
TIFF_TO_PS_CONVERTER=FAX2PS  # set to TIFF2PS for nicer ps

...
...
FaxDispatch
..
if $FILETYPE is not ps then TIFF_TO_PS_CON...=TIFF2PS


I think the definitive solution would be to add the tiff2fax binary to the ones
that faxsetup searches for and adds the path to etc/setup.cache

so you could do
if [ -x $TIFF2FAX ]; then
	TIFF_2_PS_CONVERTER=$TIFF2FAX	
else
	TIFF_2_PS_CONVERTER=$PS2FAX	
fi

diff -Nur hylafax-4.1.orig/configure hylafax-4.1/configure
--- hylafax-4.1.orig/configure  Thu May 31 04:29:46 2001
+++ hylafax-4.1/configure   Mon Jul  2 14:13:23 2001
@@ -237,6 +237,7 @@
 TARGET
 TIFFBIN
 TIFFINC
+TIFF2PS
 UTMP
 UUCP_LOCKDIR   DIR_LOCKS
 UUCP_LOCKTYPE  LOCKS
@@ -3339,6 +3340,7 @@
 test "$RMCMD"  || RMCMD=`findAppDef rm $PATH rm`
 test "$SORT"   || SORT=`findAppDef sort $PATH sort`
 test "$STRIP"  || STRIP=`findAppDef strip $PATH strip`
+test "$TIFF2PS"    || TIFF2PS=`findAppDef tiff2ps $PATH tiff2ps`
 # NB: can't test $PWD 'cuz it's a shell variable
 PWD=`findApp pwd $PATH`       || PWD=pwd
 diff -Nur hylafax-4.1.orig/etc/faxsetup.sh.in hylafax-4.1/etc/faxsetup.sh.in
--- hylafax-4.1.orig/etc/faxsetup.sh.in Thu Jun 14 07:36:16 2001
+++ hylafax-4.1/etc/faxsetup.sh.in  Mon Jul  2 14:14:05 2001
@@ -64,6 +64,7 @@
 RMCMD=@RM@         # remove file for use below
 SCRIPT_SH=@SCRIPT_SH@      # shell for use below
 SED=@SED@          # sed for use below
+TIFF2PS=@TIFF2PS@      # tiff2ps command to dump in setup.cache
 
 FAX=fax                # identity of the fax user
 SERVICES=/etc/services     # location of services database
@@ -157,6 +158,7 @@
 SPOOL      DIR_SPOOL
 SYSVINIT
 TIFFBIN
+TIFF2PS
 TARGET
 UUCP_LOCKDIR   DIR_LOCKS
 UUCP_LOCKTYPE  LOCKS"



-- 
giulioo@pobox.com


____________________ HylaFAX(tm) Users Mailing List _______________________
 To unsub: mail -s unsubscribe hylafax-users-request@hylafax.org < /dev/null