commit a80a55dc3f2a2c9cc8af53524e5f081bdf5b5f8c Author: David King Date: Sun Nov 30 21:38:33 2014 +0000 Update NEWS for 2.3.2 release M NEWS M SOURCES M configure.ac commit 08f5ac591a8af07c513ced6cf356e8048a15a179 Author: David King Date: Sun Nov 30 20:38:23 2014 +0000 Update British English translation M po/en_GB.po commit 3e41239e437f8deda54e731e9ec13db55f7b20f5 Author: Piotr Drąg Date: Sun Nov 30 18:19:09 2014 +0100 Updated Polish translation M po/pl.po commit bea6a388583970ac506f5d6f21d59a3b256e8fa4 Author: David King Date: Fri Nov 28 21:42:50 2014 +0000 Use a separator row in the album view M data/browser.ui M src/browser.c commit 20190badece12683366ce9da0e793f4bf2432f59 Author: David King Date: Fri Nov 28 21:39:46 2014 +0000 Remove unused PangoStyle columns from album models M data/browser.ui M src/browser.c commit 06650c56f7b4443a483b434d8ce4121e9818936e Author: Marek Černocký Date: Wed Nov 26 07:17:22 2014 +0100 Updated Czech translation M po/cs.po commit b6e9d66d8a305209160706bd916f2f7282055063 Author: David King Date: Mon Nov 24 21:43:49 2014 +0000 Add several picture type strings Improve the heuristic for guessing the image type from the filename. https://bugzilla.gnome.org/show_bug.cgi?id=740654 M src/picture.c M src/picture.h M tests/test-picture.c commit df635e253dceb93befa0ea6e9054ef0126c7d624 Author: Marek Černocký Date: Mon Nov 24 20:10:03 2014 +0100 Updated Czech translation M po/cs.po commit ac50c03cafefa2b1f3c8e579167a12e47762eadb Author: David King Date: Sat Nov 22 16:52:22 2014 +0000 Remove unused argument from Ogg reading function M src/tags/ogg_tag.c M src/tags/ogg_tag.h M src/tags/opus_tag.c commit 38ba361b46a1d00d93252cbecfb3afb9ffd8c839 Author: David King Date: Fri Nov 21 23:18:16 2014 +0000 Add tests for several picture functions M Makefile.am M src/picture.c M src/picture.h M src/tag_area.c A tests/test-picture.c commit 4fcfe2136e8c36d3ca7f757bf453c07cf7742ebc Author: David King Date: Fri Nov 21 19:33:47 2014 +0000 Add tests for DLM function Additionally, improve the metric reporting to report 0 as a minimum result fot the "similarity metric". M Makefile.am M src/dlm.c M src/dlm.h A tests/test-dlm.c commit d5c3569e076486c46ce1d4a3a86476c4c00553d8 Author: David King Date: Fri Nov 21 16:38:26 2014 +0000 Add simple test for Convert_Duration() M Makefile.am A tests/test-misc.c commit 084f04adc487f21bc768835d37709fe7626ac934 Author: David King Date: Fri Nov 21 16:34:10 2014 +0000 Move busy cursor handling to application window Avoid the deprecated gdk_cursor_new(), and instead use gdk_cursor_new_for_display(). M src/application.c M src/application_window.c M src/application_window.h M src/easytag.c M src/misc.c M src/misc.h commit 3d5ccb51e67997cf4f18ad9bb10923f86faa2324 Author: David King Date: Thu Nov 20 23:54:06 2014 +0000 Remove unused et_get_file_size() Additionally, tidy up some unnecessary misc.h prototypes. M src/misc.c M src/misc.h commit 6456cdfc6bad7e48670bb380cdb42c905d48a4ed Author: David King Date: Thu Nov 20 23:36:03 2014 +0000 Move file selection dialogs to application window M src/browser.c M src/misc.c M src/misc.h commit a9d84f50b48c2398e39800d355b0e4ea24e6bd5f Author: David King Date: Thu Nov 20 22:37:33 2014 +0000 Return a GError when launching external programs Consistently return a GError when reporting failures to launch external applications, and allow the calling code to show the error to the user as necessary. M src/application_window.c M src/browser.c M src/misc.c M src/misc.h commit afed1362d87b1c070de448dffad7bc5d06929ecd Author: David King Date: Thu Nov 20 21:32:19 2014 +0000 Fix launching an external application Only display a warning if the program name is empty. Move the status bar message printed on successful program execution to EtBrowser. M src/browser.c M src/misc.c commit c8d869280f4d4ed34444bcd1da563715341d1a60 Author: David King Date: Wed Nov 19 16:59:03 2014 +0000 Fix memory leaks in Save_File() error paths M src/easytag.c commit 72ec45e6bb209e9029ba13f6663d0f0a48ab8378 Author: David King Date: Fri Nov 14 22:19:35 2014 +0000 Make file list selection independent of direction When selecting a range from a row which is below the current view, do not scroll to the bottom of the selection, and instead ensure that the row which was clicked most-recently is the one which is shown in the tag area. https://bugzilla.gnome.org/show_bug.cgi?id=740134 M src/browser.c commit c11c8b5abf3e19f186db4f9290e24e008bb5e5a5 Author: David King Date: Sun Nov 9 14:05:43 2014 +0000 Set a GError in id3tag_write_file_v24tag() When returning FALSE to indicate an error, always set the passed-in GError. M src/tags/id3v24_tag.c commit 1b4bb5b25860bb784e50fd84a373889fe45cea4c Author: David King Date: Sat Nov 8 18:45:59 2014 +0000 Fix tag split setting for composer in FLAC M src/tags/flac_tag.c commit cae160ebfd27b3d99a689732ec8c69f2d96a44e8 Author: David King Date: Sat Nov 8 10:05:48 2014 +0000 Remove unused log.h include from tagging code M src/tags/ape_tag.c M src/tags/flac_tag.c M src/tags/id3_tag.c M src/tags/id3v24_tag.c M src/tags/mp4_tag.cc M src/tags/ogg_tag.c M src/tags/opus_header.c M src/tags/opus_tag.c commit 24fdf0b83665a64b52f3ceacdcff552fbe4fbf2a Author: David King Date: Sat Nov 8 10:02:40 2014 +0000 Switch log message to debug in Ogg image handling Any images which cannot be converted to the specification-required PNG on JPEG are left unchanged, so emitting a log message is less than helpful. M src/tags/ogg_tag.c commit 5e6686d300e7500a2c3e90d2c82e3465837e7ea8 Author: David King Date: Fri Nov 7 19:33:05 2014 +0000 Force a margin between the tag label and the tabs Add a GtkBox as a container for the tag label, so that the margin is applied when using it as an action widget in the tag area notebook. M data/tag_area.ui commit 7d2e5f3f1a1a72f9cccad38583480a7f4d1116dc Author: David King Date: Fri Nov 7 19:02:15 2014 +0000 Allow the tag area image treeview to expand Repack the tag area and file are into a GtkGrid rather than a GtkBox, and allow the images treeview to expand, so that the tag area expands vertically if there is room. https://mail.gnome.org/archives/easytag-list/2014-November/msg00005.html M data/tag_area.ui M src/application_window.c commit 871ec1c8c2e0f08a665c881c09548314d0fc5ade Author: David King Date: Fri Nov 7 08:39:45 2014 +0000 Fix process-fields setting handling in scanner Connect solely to the GSettings changed signal, rather than also connecting to the toggled signal on the check buttons. This ensures that the state is updated only when the GSettings key changes, avoiding inconsistent behaviour when unselecting the last selected field. https://bugzilla.gnome.org/show_bug.cgi?id=739756 M src/scan_dialog.c commit eadb07b3556a7f3c0a69c3e896a83876bf4b45f6 Author: David King Date: Fri Nov 7 08:26:19 2014 +0000 Fix double unref when opening an invalid Ogg file M src/tags/vcedit.c commit c60fd9f91e9e106c20d9d322884861b9bbe19002 Author: David King Date: Fri Nov 7 08:18:14 2014 +0000 Refactor Ogg file ID3v2 skipping logic Mark the Ogg file as modified while reading, if it has an ID3v2 tag, as it will be removed while saving. Remove a double unref of the input stream in an error path. Tidy up several obsolete seeks. M src/tags/ogg_tag.c commit 9d1e4dc1bba908fcf4cb99b136aa0184d16be699 Author: David King Date: Thu Nov 6 22:08:52 2014 +0000 Do not warn about ID3v2 tags when saving Ogg files The Ogg tag writing code can handle ID3v2 tags without problems, and a warning is already logged when reading the file, so warning again when saving is not helpful. M src/tags/ogg_tag.c commit 03418dd249116b985e114023622fccdc426d904a Author: David King Date: Thu Nov 6 21:59:59 2014 +0000 Fix skipping over ID3v2 tags in Ogg files According to the documentation for ogg_sync_pageout(), a return value of -1 means that bytes were skipped, and so it is fine to continue reading. Fixes writing to Ogg files where an ID3v2 tag is present. https://bugzilla.gnome.org/show_bug.cgi?id=739748 M src/tags/vcedit.c commit 4a67851124bf2b9a64e232e773a19badb3d18aff Author: David King Date: Thu Nov 6 16:33:18 2014 +0000 Move extended date field warning out of tag code M src/et_core.c M src/tags/flac_tag.c M src/tags/ogg_tag.c commit b83f270dca352a67c299a23f320fda6823f710da Author: David King Date: Thu Nov 6 16:23:40 2014 +0000 Emit a critical warning for invalid FLAC artwork This should only happen if gdk-pixbuf supplies bogus data, so it should not use Log_Print() to log a massage to the UI. M src/tags/flac_tag.c commit 6a17785ed0dfcdb1638aafd1227bc5c8e649d3ba Author: David King Date: Thu Nov 6 07:59:32 2014 +0000 Avoid a crash when reading empty FLAC tags https://bugzilla.gnome.org/show_bug.cgi?id=739694 M src/tags/flac_tag.c commit 728b3f71276dd259f1e730ab1b48ed06fe176892 Author: David King Date: Thu Nov 6 07:38:01 2014 +0000 Do not force-enable the log visiibility on startup https://bugzilla.gnome.org/show_bug.cgi?id=739696 M src/application_window.c commit fcfd471746ac34741ab47e6d724026aab6072f5b Author: David King Date: Wed Nov 5 17:41:25 2014 +0000 Make the application name translatable M data/easytag.desktop.in M src/about.c M src/application.c M src/application_window.c commit c4e35451b5b0f95a4cc63779b112012ff9435955 Author: Piotr Drąg Date: Wed Nov 5 13:38:23 2014 +0100 Updated Polish translation M po/pl.po commit 642fae6e3d3754842ef702789ba134e98058f262 Author: Мирослав Николић Date: Wed Nov 5 05:13:22 2014 +0100 Added Serbian translation M po/sr.po M po/sr@latin.po commit ac3c5a6f7e56b287ab2c2ec8c801b4cd0b88b06b Author: David King Date: Tue Nov 4 16:42:34 2014 +0000 Fix several CDDB response memory leaks M src/cddb_dialog.c commit de33ecf87262d39cf6a953ec64b12df810d3b000 Author: David King Date: Tue Nov 4 16:41:58 2014 +0000 Fix memory leak of a path in a browser error path M src/browser.c commit ba3305e91043f1960c94f6343d343adf50060a2b Author: David King Date: Tue Nov 4 08:40:46 2014 +0000 Improve copying extra tags between files Prepend to the GList, and then reverse it afterwards. M src/et_core.c commit 8efaf8c913219114beaccb4fc9dc009879cb8852 Author: David King Date: Mon Nov 3 23:58:28 2014 +0000 Fix leak of selected row list in CDDB dialog M src/cddb_dialog.c commit 966745009352e0d9c2c22bb523be2a569907b7fd Author: David King Date: Mon Nov 3 23:31:29 2014 +0000 Fix filename leak in browser DLM selection M src/browser.c commit b08fef9f394dc89bd5138412bf204fcb14d48116 Author: David King Date: Mon Nov 3 23:00:52 2014 +0000 Fix more CDDB track number memory leaks M src/cddb_dialog.c commit 6cfe0b7cb430c849ef2c303d8df5e1b7b51b8bb7 Author: David King Date: Mon Nov 3 22:15:56 2014 +0000 Fix leaks of track number strings in CDDB dialog M src/cddb_dialog.c commit 6582f1aa3933ed096342be3cbf8d4851b9c048bb Author: David King Date: Mon Nov 3 22:14:20 2014 +0000 Fix a memory leak when searching albums via CDDB M src/cddb_dialog.c commit 7845f0616b1a7c16a16d7d3bc46e494fc93ab5ce Author: David King Date: Mon Nov 3 21:17:54 2014 +0000 Simplify character pointer syntax in CDDB dialog M src/cddb_dialog.c commit 0ce66082495a2f5c0400a9e25966509045fe1021 Author: Ekaterina Gerasimova Date: Mon Nov 3 21:11:30 2014 +0000 Update strings to use ‘spaces’ and ‘underscores’ Use the words ‘spaces’ and ‘underscores’ instead of ‘ ’ and ‘_’, which is more consistent with other instances of both in the preferences. M data/scan_dialog.ui M src/tag_area.c commit 43b160afef98e9cebc83a83caed2d7ccf576ecdf Author: Ekaterina Gerasimova Date: Mon Nov 3 21:06:50 2014 +0000 Add description to help index M help/C/index.page commit f2f46357576758ed3d3d6b0cf26520edd5aed95a Author: David King Date: Mon Nov 3 18:43:38 2014 +0000 Fix incorrect track duration in CDDB results M src/cddb_dialog.c commit cef074fd5f2bd538817577d5ca93d6d4e3c3c20e Author: David King Date: Sun Nov 2 18:48:42 2014 +0000 Set the GError when failing to read ID3 tags M src/tags/id3v24_tag.c commit 7ef0e7569cb0108debe6bac95cd7ece1ac39f3a6 Author: David King Date: Fri Oct 31 23:09:51 2014 +0000 Add AppData metainfo file for Nautilus extension M .gitignore M Makefile.am A data/easytag-nautilus.metainfo.xml.in M po/POTFILES.in commit 7476eaa86e66824092c86ba67d76265dba1cf884 Author: David King Date: Fri Oct 31 22:18:24 2014 +0000 Include name and summary in AppData M data/easytag.appdata.xml.in commit 57b277816450de8d49fb43fb8a55a4bfd9c2fb7c Author: David King Date: Fri Oct 31 19:56:28 2014 +0000 Refactor Action_Select_Nth_File_By_Etfile() Move Action_Select_Nth_File_By_Etfile() to the application window as et_application_window_select_file_by_et_file(). M src/application_window.c M src/application_window.h M src/browser.c M src/easytag.c M src/easytag.h M src/search_dialog.c