commit 34020f9dd4f497066ff79c0ab7cc534e21abc66b
Author: Matthias Clasen <mclasen@redhat.com>
Date: Fri May 14 22:03:03 2010 -0400
Updates
NEWS | 21 +++++++++++++++++++++
1 files changed, 21 insertions(+), 0 deletions(-)
commit 2ed13de1533a1fafaac97be0fdc4154eb84ac35c
Author: Matthias Clasen <mclasen@redhat.com>
Date: Fri May 14 21:58:08 2010 -0400
Fix issues with GSETTINGS_CHECK_RULE
Rename the --schema-files option to --schema-file, since it only
accepts one file at a time. Change the GSETTINGS_CHECK_RULE to
use it that way, too. And also make it work better with !srcdir
builds.
Bugs #616731 and #616864
gio/gschema-compile.c | 2 +-
gio/tests/gschema-compile.c | 2 +-
m4macros/gsettings.m4 | 5 ++---
3 files changed, 4 insertions(+), 5 deletions(-)
commit 763c1dab1f2c92526330425d77211b704668a3a3
Author: David Zeuthen <davidz@redhat.com>
Date: Fri May 14 21:08:01 2010 -0400
GDBus: Use specific variant type in GetAll()
Without this fix, we segfault if the exported object returned an error
on all get_property() calls (in reality, this never happens).
Signed-off-by: David Zeuthen <davidz@redhat.com>
gio/gdbusconnection.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
commit 4baf104f0a369348185a2e2c9fdebc1423ec7f8e
Author: David Zeuthen <davidz@redhat.com>
Date: Fri May 14 20:52:15 2010 -0400
GDBus: Fix a double free
Fix an unintentional double free introduced in commit
4ad4c306c3b80620185cf975b402e17a6174aea9.
This bug manifested itself when trying to complete this
$ gdbus introspect --system --dest <tab>
gio/gdbus-tool.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
commit 661e5ea69f2d370af6e4e9c73242cf158414dd5d
Author: Christian Persch <chpe@gnome.org>
Date: Fri May 14 20:07:15 2010 +0200
Plug mem leaks in gdbus tests & examples
Use "&s" instead of "s", and free the variant iters after use.
Bug #618663.
gio/tests/gdbus-example-peer.c | 4 ++--
gio/tests/gdbus-example-proxy-subclass.c | 12 +++---------
gio/tests/gdbus-example-server.c | 2 +-
gio/tests/gdbus-example-subtree.c | 6 +++---
gio/tests/gdbus-example-watch-proxy.c | 12 ++++--------
gio/tests/gdbus-export.c | 8 +++-----
gio/tests/gdbus-introspection.c | 2 +-
gio/tests/gdbus-peer.c | 8 ++++----
gio/tests/gdbus-proxy.c | 2 +-
9 files changed, 22 insertions(+), 34 deletions(-)
commit 60c53fef4788d4773704cb1affd2fb0f4d1d8830
Author: Christian Persch <chpe@gnome.org>
Date: Fri May 14 18:21:01 2010 +0200
Plug a mem leak in gdbusauth
From valgrind running gdbus-peer test:
==20513== 32 bytes in 1 blocks are definitely lost in loss record
1 of 15
==20513== at 0x4024E4C: realloc (vg_replace_malloc.c:429)
==20513== by 0x4079BB1: g_realloc (gmem.c:174)
==20513== by 0x4099472: g_string_maybe_expand (gstring.c:396)
==20513== by 0x409A42A: g_string_insert_c (gstring.c:1050)
==20513== by 0x42169AC: g_string_append_c_inline (gstring.h:153)
==20513== by 0x421682C: _my_g_input_stream_read_line_safe
(gdbusauth.c:336)
==20513== by 0x421843E: _g_dbus_auth_run_server (gdbusauth.c:1265)
==20513== by 0x4222B94: initable_init (gdbusconnection.c:1783)
==20513== by 0x41CF8D5: g_initable_init (ginitable.c:106)
==20513== by 0x41CFA8D: g_initable_new_valist (ginitable.c:219)
==20513== by 0x41CF920: g_initable_new (ginitable.c:139)
==20513== by 0x4223479: g_dbus_connection_new_sync
(gdbusconnection.c:2046)
Bug #618650.
gio/gdbusauth.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
commit 5bc9d43288d4991b9c3ef1fc38d231113b633ec7
Author: Christian Persch <chpe@gnome.org>
Date: Fri May 14 14:27:08 2010 +0200
Plug mem leak in g_dbus_address_get_stream_sync
==6279== 21,615 (4,708 direct, 16,907 indirect) bytes in 169
blocks are
definitely lost in loss record 12 of 13
==6279== at 0x4024D2E: malloc (vg_replace_malloc.c:207)
==6279== by 0x4079A90: g_malloc (gmem.c:135)
==6279== by 0x4079DC8: g_malloc_n (gmem.c:252)
==6279== by 0x4097E66: g_strsplit (gstrfuncs.c:2434)
==6279== by 0x42169A2: g_dbus_address_get_stream_sync
(gdbusaddress.c:875)
Bug #618622.
gio/gdbusaddress.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
commit dc39825aa3b1556e57460df1cca0b764a5741a66
Author: Christian Persch <chpe@gnome.org>
Date: Fri May 14 14:22:45 2010 +0200
Plug a mem leak in get_uninitialized_connection
Free the bus address after creating the singleton.
==26308== 39,736 (10,517 direct, 29,219 indirect) bytes in 388 blocks
are definitely lost in loss record 14 of 15
==26308== at 0x4024D2E: malloc (vg_replace_malloc.c:207)
==26308== by 0x4079A90: g_malloc (gmem.c:135)
==26308== by 0x4079DC8: g_malloc_n (gmem.c:252)
==26308== by 0x4095607: g_strdup (gstrfuncs.c:102)
==26308== by 0x4216B9A: g_dbus_address_get_for_bus_sync
(gdbusaddress.c:961)
==26308== by 0x422A7AE: get_uninitialized_connection
(gdbusconnection.c:5241)
Bug #618622.
gio/gdbusconnection.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
commit 5b2c7f10bd5a42d2956b53b13f3aabb947f901dd
Author: Christian Persch <chpe@gnome.org>
Date: Fri May 14 14:15:42 2010 +0200
Plug mem leaks in parse_value_from_blob
The result of read_string() was leaked.
Bug #618615.
gio/gdbusmessage.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
commit 0a7c0ac74bd55d06265e9441c5728119adc254ab
Author: Christian Persch <chpe@gnome.org>
Date: Fri May 14 18:08:29 2010 -0400
Plug a mem leak
This code leaked the return value of g_variant_get_child_value();
use g_variant_get() instead and free the iter when done.
gio/gdbusproxy.c | 22 +++++++++-------------
1 files changed, 9 insertions(+), 13 deletions(-)
commit ddc94bd0a65a17471e50d0c659d9c59a1804c3f1
Author: David Zeuthen <davidz@redhat.com>
Date: Fri May 14 12:55:25 2010 -0400
GDBus: Remove cached value if a property is invalidated
Also add a test case to catch this.
Signed-off-by: David Zeuthen <davidz@redhat.com>
gio/gdbusproxy.c | 6 ++++++
gio/tests/gdbus-proxy.c | 36 ++++++++++++++++++++++++++++++++++++
gio/tests/gdbus-testserver.py | 16 ++++++++++++++++
3 files changed, 58 insertions(+), 0 deletions(-)
commit bb6530eb34a16cbf34ce130c21071a25666a704b
Author: David Zeuthen <davidz@redhat.com>
Date: Fri May 14 12:49:51 2010 -0400
GDBus: Fix serialization of empty arrays
It turns out that we didn't observe padding (neither when reading nor
writing) for empty arrays which (apparently) is needed according to
the D-Bus spec and reference implementation. A simple test case to
provoke this behavior is as follows (notice the lack of 4 bytes worth
of padding at position 0x0064):
Error calling dbus_message_demarshal() on this blob:
org.freedesktop.DBus.Error.InvalidArgs: Message is corrupted
(Alignment padding not null)
0000: 6c 01 00 01 2e 00 00 00 41 00 00 00 37 00 00 00
l.......A...7...
0010: 08 01 67 00 08 73 61 7b 73 76 7d 61 73 00 00 00
..g..sa{sv}as...
0020: 01 01 6f 00 08 00 00 00 2f 66 6f 6f 2f 62 61 72
..o...../foo/bar
0030: 00 00 00 00 00 00 00 00 03 01 73 00 06 00 00 00
..........s.....
0040: 4d 65 6d 62 65 72 00 00 11 00 00 00 30 31 32 33
Member......0123
0050: 34 35 36 37 38 39 30 31 32 33 34 35 36 00 00 00
4567890123456...
0060: 00 00 00 00 0e 00 00 00 09 00 00 00 53 6f 6d 65
............Some
0070: 74 68 69 6e 67 00 thing.
The blob was generated from the following GVariant value:
('01234567890123456', @a{sv} {}, ['Something'])
If the blob was encoded using DBusMessageIter, the payload would
have been:
0000: 6c 01 00 01 32 00 00 00 41 00 00 00 36 00 00 00
l...2...A...6...
0010: 01 01 6f 00 08 00 00 00 2f 66 6f 6f 2f 62 61 72
..o...../foo/bar
0020: 00 00 00 00 00 00 00 00 03 01 73 00 06 00 00 00
..........s.....
0030: 4d 65 6d 62 65 72 00 00 08 01 67 00 08 73 61 7b
Member....g..sa{
0040: 73 76 7d 61 73 00 00 00 11 00 00 00 30 31 32 33
sv}as.......0123
0050: 34 35 36 37 38 39 30 31 32 33 34 35 36 00 00 00
4567890123456...
0060: 00 00 00 00 00 00 00 00 0e 00 00 00 09 00 00 00
................
0070: 53 6f 6d 65 74 68 69 6e 67 00
Something.
** ERROR:gdbus-serialization.c:547:check_serialization: code should
not be reached
Aborted
and this is now in the libdbus-1-using serialization test case.
Signed-off-by: David Zeuthen <davidz@redhat.com>
gio/gdbusmessage.c | 680
++++++++++++++++++++++++---------------
gio/tests/gdbus-serialization.c | 12 +
2 files changed, 439 insertions(+), 253 deletions(-)
commit 285a124608b28ca62db7350632a48bd9257038c0
Author: Jorge González <jorgegonz@svn.gnome.org>
Date: Fri May 14 17:55:37 2010 +0200
Updated Spanish translation
po/es.po | 1026
+++++++++++++++++++++++++++++++------------------------------
1 files changed, 521 insertions(+), 505 deletions(-)
commit 02af71c7ff9689a75069b0a7bc84349dac0b13b4
Author: Matthias Clasen <mclasen@redhat.com>
Date: Fri May 14 11:49:15 2010 -0400
bump version
configure.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
commit cff9d83f75b90301909f2c7d46a16e5f618e3e0b