commit 0749199d4cd46190fd649ab72af2001baefbf791 Author: Matthias Clasen Date: Tue Jul 21 08:37:02 2015 -0400 3.16.6 NEWS | 23 +++++++++++++++++++++++ configure.ac | 4 ++-- 2 files changed, 25 insertions(+), 2 deletions(-) commit 434c7220d70e713d062deff90746a3e1a758e83c Author: Stefan Sauer Date: Mon Jul 20 21:02:39 2015 +0200 gtkimagemenuitem: improve the replacement docs even more Since the stock strings usually have menmosics suggest gtk_menu_item_new_with_mnemonic(). gtk/deprecated/gtkimagemenuitem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 64954444aeae0dfc39c8d7a36c8ed60d66c7574f Author: Stefan Sauer Date: Mon Jul 20 20:54:52 2015 +0200 gtkimagemenuitem: fix suggestion for replacement gtk_menu_item_new(9 would create an empty menu item. While the stock deprecation aims to unclutter the menus, I feel this goes too far. gtk/deprecated/gtkimagemenuitem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6978db3a52a5cb3b3eca17a7569f432bce87ca1f Author: Matthias Clasen Date: Sun Jul 19 22:08:36 2015 -0400 GtkListBox: Listen for adjustment changes We automatically pick up an adjustment from our parent scrollable, but we failed to update it when it changes. This is happening in the places sidebar, and it was causing the focus-tracking to fail there, letting the focus move out of view. With this change, the focus remains visible. gtk/gtklistbox.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) commit 1debaed6765e7f7289ee9893c12b82998adec58d Author: Daniel Hams Date: Thu Jul 16 17:22:07 2015 +0100 GdkGLContext little fix to property names and descriptions. https://bugzilla.gnome.org/show_bug.cgi?id=752502 gdk/gdkglcontext.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit b695d7392ac407a3d9123fd55debba278c27af4b Author: Ignacio Casal Quinteiro Date: Fri Jul 17 09:31:32 2015 +0200 gdk: fix crash if visual is NULL cairo_xlib_surface_get_visual might return NULL so we need to check for NULL before trying to use it. https://bugzilla.gnome.org/show_bug.cgi?id=752520 gdk/x11/gdkglcontext-x11.c | 3 +++ 1 file changed, 3 insertions(+) commit fe783cf271123779edb25abef6e265564447cdef Author: Emmanuele Bassi Date: Thu Jul 16 14:53:42 2015 +0100 tests/gears: Ensure we don't use unavailable GL resources We need to check on realize if we have access to a GL context, before calling GL functions. We use gtk_gl_area_get_error() for that. We also need to tear down the resources during unrealization, instead of leaking them. tests/gtkgears.c | 122 +++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 87 insertions(+), 35 deletions(-) commit b9e0a54a420375a8132487db1a6ce320ff67c8de Author: Eric Williams Date: Tue Jul 7 14:54:32 2015 -0400 Added an additional explanation and code snippet for GtkImageMenuItem.c https://bugzilla.gnome.org/show_bug.cgi?id=752093 gtk/deprecated/gtkimagemenuitem.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) commit 0002a8a604905254f5d2e0a25bcb17fc53af8979 Author: Ryan Lortie Date: Mon Jul 6 09:40:48 2015 -0400 testgmenu: use the menu binding code The menu tracker does a better job of this than we can, so move over to using it instead. This fixes issues with './testgmenu --import' not properly displaying the language submenu. https://bugzilla.gnome.org/show_bug.cgi?id=752016 tests/testgmenu.c | 387 ++---------------------------------------------------- 1 file changed, 14 insertions(+), 373 deletions(-) commit b46b40bbc63db2b947395c759ac14a0f89137f72 Author: Carlos Garnacho Date: Tue Jul 7 12:50:14 2015 +0200 gtkdnd: Fix introspection annotations in some functions The GdkEvent field is nullable on gtk_drag_begin*, and gtk_drag_cancel() is a method, like the rest of the DnD API. gtk/gtkdnd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 542413fecaa57b14eb6a6f89e54e3a6eb3b4c6e5 Author: Carlos Garnacho Date: Mon Jul 6 19:33:49 2015 +0200 gtkdnd: Account for setting a same icon helper g_set_object() will take care of ref'ing before destroying the previous instance, which might actually be the same pointer. https://bugzilla.gnome.org/show_bug.cgi?id=751401 gtk/gtkdnd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit fe104915e480718728d589d780492a5b0162e089 Author: nick Date: Mon Jun 29 20:37:26 2015 +0100 settings: Include pangofc-fontmap.h header on Wayland In case the X11 backend is not enabled, we still need to include the pangofc-fontmap.h header file, as we use the Pango/FontConfig API in both the X11 and Wayland case. https://bugzilla.gnome.org/show_bug.cgi?id=751625 gtk/gtksettings.c | 1 + 1 file changed, 1 insertion(+) commit 4d049c989b2553cd924b9e5eca9006ac33f7a1ff Author: Marek Černocký Date: Sat Jul 18 09:42:01 2015 +0200 Updated Czech translation po-properties/cs.po | 906 ++++++++++++++++++++++++++-------------------------- 1 file changed, 457 insertions(+), 449 deletions(-) commit 34a2c6a2eec8ee23a7ad164decab770994a53e72 Author: Matthias Clasen Date: Fri Jul 17 20:46:11 2015 -0400 Fix the build gtk/inspector/object-tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 074fd13350a35b7fe68705b0eb3d73686b6ef763 Author: Matthias Clasen Date: Fri Jul 17 19:54:09 2015 -0400 testgtk: Remove pointless code The display is getting overwritten immediately. Pointed out by coverity. tests/testgtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c9267b30d7c91ab07e5a3c693e8dfd4782b2d27f Author: Matthias Clasen Date: Fri Jul 17 19:52:52 2015 -0400 inspector: Avoid a NULL deref Coverity pointed out that getting a class name requires dereferencing the pointer, so only don't do it if it is NULL. gtk/inspector/object-tree.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 6ea7c290a34d27a2f125f2e93147d2f2fcbc1634 Author: Matthias Clasen Date: Fri Jul 17 19:19:24 2015 -0400 GtkWindow: Fix a use-after-free We were printing a string in a warning after freeing it. Also, fix an x/y typo that might cause popovers to be mispositioned. gtk/gtkwindow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 0993cdf79f24c826121c9c0930de2b5fbbde6e47 Author: Matthias Clasen Date: Fri Jul 17 19:23:43 2015 -0400 file chooser: remove an unused GError variable Pointed out by coverity gtk/gtkfilechooserwidget.c | 5 ----- 1 file changed, 5 deletions(-) commit 32c81cfd658e5ed3850b6a44f4240f75c5ce19d1 Author: Matthias Clasen Date: Fri Jul 17 18:47:39 2015 -0400 inspector: Remove some dead code Not sure what I was thinking here. Coverity pointed this out. gtk/inspector/prop-list.c | 6 ------ 1 file changed, 6 deletions(-) commit 575f334ce50cebfc5d29f5502162103387ec7e0e Author: Matthias Clasen Date: Fri Jul 17 18:42:24 2015 -0400 inspector: Avoid a NULL deref gtk/inspector/prop-editor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 48fba6911aa436fc55296001ce4dd0161605981b Author: Matthias Clasen Date: Fri Jul 17 18:41:14 2015 -0400 treeview: Add an explicit return for clarity I believe that first_column can only ever be NULL here if last_column is NULL too, in which case we'd exited already. But coverity doesn't see that, so add an explicit exit. gtk/gtktreeview.c | 3 +++ 1 file changed, 3 insertions(+) commit d833c05f6e4f2ec7345e5cde20ec9637ebef6be7 Author: Matthias Clasen Date: Fri Jul 17 18:40:37 2015 -0400 tooltip: Remove unnecessary checks Coverity uses these as clues to complain. gtk/gtktooltip.c | 62 +++++++++++++++++++++++++++----------------------------- 1 file changed, 30 insertions(+), 32 deletions(-) commit 66f9dcd93b125f93a941a40453aac15f9f99c521 Author: Matthias Clasen Date: Fri Jul 17 18:40:11 2015 -0400 list box: Remove unnecessary checks Again, coverity takes these as clues to complain. gtk/gtklistbox.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 236d2d3cf1c2a77ef1716a86e838696b1c1a2324 Author: Matthias Clasen Date: Fri Jul 17 18:39:14 2015 -0400 GtkLabel: Remove an unnecessary check Coverity has the annoying habit of guessing backwards that if we check the value here, it might be NULL earlier. gtk/gtklabel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ff9349bfdd71208f56901fec0ad7d814a029e7a4 Author: Matthias Clasen Date: Fri Jul 17 18:38:01 2015 -0400 GtkActionHelper: Avoid null deref in debug code gtk/gtkactionhelper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2f817322fd6afaa0ceb276931cb896dffc14dc56 Author: Matthias Clasen Date: Fri Jul 17 18:38:30 2015 -0400 GtkGrid: Add a few NULL checks Coverity complained about these. gtk/gtkgrid.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 5557dd8fcee9c138c8207b4b8ffb25bed7737483 Author: Matthias Clasen Date: Fri Jul 17 18:37:20 2015 -0400 gdk: Add some parameter checking This may help coverity recognize that we're not called with invalid combinations. gdk/gdkwindow.c | 2 ++ 1 file changed, 2 insertions(+) commit ff7d67b33cfa2b070eb94e21f2cf42f5497ff221 Author: Matthias Clasen Date: Fri Jul 17 15:59:23 2015 -0400 testdialog: Error out if templates are missing Coverity complained about us ignoring the return value here, and it is nicer to get an error message about this. tests/testdialog.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 3460a4d507ebee6d3e5c17cd25da2f179ab0ce01 Author: Matthias Clasen Date: Fri Jul 17 15:58:24 2015 -0400 cups: Annotate a call whose return value we don't care about We're closing this fd, but we're not going to do anything else if that fails. Annotate to let coverity see this. modules/printbackends/file/gtkprintbackendfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5bbf0baa7f1f7e146ff00cb6256279245561be8e Author: Matthias Clasen Date: Fri Jul 17 15:56:34 2015 -0400 inspector: Check a return value We don't care about the error here, but we were relying on g_resources_get_info to zero the size even in case of error. No need to do that, we can just check the return value. Plus, it makes coverity happy. gtk/inspector/resource-list.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 2c7974a69d2d924f1b0ee18efd338a39101762e7 Author: Matthias Clasen Date: Fri Jul 17 15:55:18 2015 -0400 inspector: Annotate a call whose return value we don't need The way this code is written, we know that there is an item in the hash table and the iter_next call will give it to us, so no need to check the return value. Annotate the call to tell coverity. gtk/inspector/gestures.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 64affb0406dd3ce0f54c60d80524848fca94bb9c Author: Matthias Clasen Date: Fri Jul 17 15:54:40 2015 -0400 gtkicontheme: Check a return value We were already looking at the error anyway, but rewriting things this way lets coverity see the light. gtk/gtkicontheme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 0558b0c439d72b8b4649255f4a5086a2b49b59fd Author: Matthias Clasen Date: Fri Jul 17 15:52:22 2015 -0400 gtkbuilderparser: Add some assertions Add some assertions that things are non-NULL when we know they are, so that coverity gets it. gtk/gtkbuilderparser.c | 3 +++ 1 file changed, 3 insertions(+) commit 7566066000d1640fddca8cad65967cafeb6c80dc Author: Matthias Clasen Date: Fri Jul 17 15:51:05 2015 -0400 gtk-demo: Check a return value Found by coverity. demos/gtk-demo/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 683ccd28e80891bc053b3c9d60a39d72926b11ad Author: Balázs Úr Date: Fri Jul 17 14:14:46 2015 +0000 Updated Hungarian translation po-properties/hu.po | 880 ++++++++++++++++++++++++++-------------------------- 1 file changed, 441 insertions(+), 439 deletions(-) commit 7c35d52f3c3b0079cd6c9b188ec36e732b998720 Author: Carlos Garnacho Date: Wed Jul 15 23:45:49 2015 +0200 Revert "x11: Query pointer devices' scroll valuators on toplevel enter events" This reverts commit 3d9cce79cf16bce335599b3b78b6bd0a04e37560. The commit broke more scenarios than fixed, better to go back to square one. gdk/x11/gdkdevice-xi2.c | 39 ++++++++++++++++----------------------- gdk/x11/gdkdevicemanager-xi2.c | 15 ++++++++++----- gdk/x11/gdkprivate-x11.h | 2 -- 3 files changed, 26 insertions(+), 30 deletions(-) commit 1a8e9dbb8ffc826c7cbae6b276629db4a11fef8f Author: Owen W. Taylor Date: Wed Jul 15 12:38:38 2015 -0400 GdkDisplayX11: Properly translate server timestamps from _NET_WM_FRAME_* messages When using frame times from _NET_WM_FRAME_DRAWN and _NET_WM_FRAME_TIMINGS, we were treating them as local monotonic times, but they are actually extended-precision versions of the server time, and need to be translated to monotonic times in the case where the X server and client aren't running on the same system. This fixes rendering stalls when using X over a remote ssh connection. https://bugzilla.gnome.org/show_bug.cgi?id=741800 gdk/x11/gdkdisplay-x11.c | 43 ++++++++++++++++++++++++++++++++++++++++++- gdk/x11/gdkdisplay-x11.h | 6 ++++++ 2 files changed, 48 insertions(+), 1 deletion(-) commit bb1750c05f8cd4aaf2623303fe8879950f65742d Author: Aurimas Černius Date: Fri Jul 10 00:08:44 2015 +0300 Updated Lithuanian translation po-properties/lt.po | 884 ++++++++++++++++++++++++++-------------------------- 1 file changed, 443 insertions(+), 441 deletions(-) commit afa82a63a9871f4e8a58513d1329efa283cfec5a Author: Matej Urbančič Date: Wed Jul 8 15:39:00 2015 +0200 Updated Slovenian translation po-properties/sl.po | 340 +++++++++++++++++++++++++++------------------------- 1 file changed, 174 insertions(+), 166 deletions(-) commit 657d0d79b3de62292cf1fd29ee3c060e89884c1b Author: Piotr Drąg Date: Tue Jul 7 20:26:24 2015 +0200 Updated Polish translation po-properties/pl.po | 4393 ++++++++++++++++++++++++++------------------------- 1 file changed, 2216 insertions(+), 2177 deletions(-) commit 1539cdd783464e6a9aa44b00758018bfba055dc8 Author: Tom Schoonjans Date: Mon Jul 6 17:34:37 2015 +0200 gdkwindow-quartz: partial aspect ratio support Support was added for GDK_HINT_ASPECT in gdk_quartz_window_set_geometry_hints though with one restriction: min_aspect and max_aspect have to be equal, which I believe corresponds to the most common usage. A warning will be printed if this condition is not met but min_aspect will be used anyway. gdk/quartz/gdkwindow-quartz.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)